fake-name
setVisibleSize deprecated
Hi First of all, excellent work and thank you for sharing! I've been looking for something like this for a while now, and I'll start building my project around that.
"setVisibleSize" is running every time you instantiate a ChromeContext, would you consider making that optional? Apart from the fact that it is deprecated, in most of my use cases I wouldn't want to have that running.
If you agree, happy to put in a pull request.
Thank you!
I think the reason I did that is I wasn’t sure what size the window would be when run headless.
In any event, I don’t see any reason it could not be disabled by default.
Sent from my phone. Please excuse my brevity.
On Apr 5, 2022, at 05:19, valeonte @.***> wrote:
Hi First of all, excellent work and thank you for sharing! I've been looking for something like this for a while now, and I'll start building my project around that.
"setVisibleSize" is running every time you instantiate a ChromeContext, would you consider making that optional? Apart from the fact that it is deprecated, in most of my use cases I wouldn't want to have that running.
If you agree, happy to put in a pull request.
Thank you!
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.
