ua-parser-js icon indicating copy to clipboard operation
ua-parser-js copied to clipboard

Testing on Chrome, Firefox, and Edge version 100?

Open jparismorgan opened this issue 2 years ago • 3 comments

This article points out concerns about Chrome, Firefox, and Edge hitting version 100 and the impact of that on user agent parsing libraries: https://www.theverge.com/2022/2/17/22938721/chrome-firefox-edge-version-100-websites-bug-compatibility-issues-mozilla-google-microsoft

Has there been testing of ua-parser-js on whether anything will be broken?

jparismorgan avatar Feb 17 '22 19:02 jparismorgan

Ended up testing and things look okay: https://github.com/faisalman/ua-parser-js/pull/568

jparismorgan avatar Feb 17 '22 20:02 jparismorgan

The bug can be happened when comparing version number using string, like what was once found in slack [1]

if (browser.version > '52')

up until '99' the result would still be TRUE but once the browser is turning '100' it would be FALSE, which is not the intended result.

[1] https://github.com/webcompat/web-bugs/issues/67866

faisalman avatar Feb 27 '22 04:02 faisalman

Thanks @faisalman, so you can also confirm you believe things will work for version 100? If so please go ahead and close this issue!

Also, calling out a comment on the PR in which I added tests for browser version 100: https://github.com/faisalman/ua-parser-js/pull/568#issuecomment-1047784152

My understanding is this will work until Chrome 107 - https://blog.chromium.org/2021/09/user-agent-reduction-origin-trial-and-dates.html - after that user agent string will be with reduced information and from that point forward folks should rely on navigator.userAgentData ie. the User Agent Client Hints - https://web.dev/user-agent-client-hints/

Feature request for Client Hints -> https://github.com/faisalman/ua-parser-js/issues/408

This already has a general feature request, but given things will break in Chrome 107, I wanted to flag it as particularly concerning.

jparismorgan avatar Feb 27 '22 21:02 jparismorgan

Closed by #568

faisalman avatar Dec 08 '22 02:12 faisalman