ua-parser-js icon indicating copy to clipboard operation
ua-parser-js copied to clipboard

Published 20 hours ago • verified publisher icon faisalman

iOS devices not read with detail model information

Open qingzhuozhen opened this issue 2 years ago • 1 comments

It seems for apple devices, the library is not reading detail model information but just general iphone, ipad, etc. For example, for user agent Mozilla/5.0 (iPhone; CPU iPhone OS 13_3_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Mobile/15E148 [FBAN/FBIOS;FBDV/iPhone12,5;FBMD/iPhone;FBSN/iOS;FBSV/13.3.1;FBSS/3;FBID/phone;FBLC/en_US;FBOP/5;FBCR/] the library is reading device model as iPhone, but not iPhone12,5, which could tell this is from iPhone 11 Pro Max. Ideally we should have mode detail model information in devices if possible.

qingzhuozhen avatar Sep 06 '21 04:09 qingzhuozhen

Just created an PR https://github.com/faisalman/ua-parser-js/pull/521 to fix this issue

qingzhuozhen avatar Sep 06 '21 04:09 qingzhuozhen

Fixed in https://github.com/faisalman/ua-parser-js/commit/a1d816ae21e18c8debbe5f23657a0ce750290317

faisalman avatar Mar 20 '23 19:03 faisalman