ua-parser-js icon indicating copy to clipboard operation
ua-parser-js copied to clipboard

Published 20 hours ago • verified publisher icon faisalman

Mac OS rebranded to macOS as of Sierra

Open valeriansaliou opened this issue 7 years ago • 7 comments

See:

  • http://www.theverge.com/2016/6/8/11891626/apple-rebrand-os-x-mac-os-evidence-mounts

Apple source:

  • http://www.apple.com/macos/sierra/

FYI, I consider all previous Mac OS version to be rebranded to macOS too. Let me know if I should apply a per-version detection, ie. detect if macOS version < 10.12 and call it Mac OS, else call it macOS.

valeriansaliou avatar Jan 19 '17 07:01 valeriansaliou

Does this have a chance to be merged?

@valeriansaliou, you have a failing test since there needs to be a Mac OS renaming there as well.

astorije avatar Apr 30 '17 01:04 astorije

Done, fixed tests 👍

valeriansaliou avatar Apr 30 '17 04:04 valeriansaliou

This breaks backwards compatibility with anyone checking for the "Mac OS", in a pretty nasty and hard to spot way.. I don't think it's a good idea.

Seldaek avatar May 17 '17 07:05 Seldaek

Then I guess it would be a better idea to only include this change in a MAJOR semver release

valeriansaliou avatar May 17 '17 09:05 valeriansaliou

Since this project is still a 0.x, then bumping the minor (to 0.8) is appropriate for a breaking change to respect semver :)

astorije avatar May 17 '17 13:05 astorije

What's the status on this PR?

erikgaal avatar Jan 21 '19 11:01 erikgaal

#LOCK33Creator>o(tab)

33Crypto avatar Aug 08 '21 02:08 33Crypto