Fairy-Stockfish icon indicating copy to clipboard operation
Fairy-Stockfish copied to clipboard

Published 20 hours ago • verified publisher icon fairy-stockfish

Musketeer variant

Open alperatalayn opened this issue 11 months ago • 4 comments

alperatalayn avatar Mar 05 '24 11:03 alperatalayn

Thank you. Since there already are several other open PRs review will likely take some time. Could you please in the meantime try to fix the errors/warnings reported by CI?

ianfab avatar Mar 12 '24 09:03 ianfab

@alperatalayn @cross-of-north @sayantandey @chris-heldeis Thanks for your PRs. May I ask you to align on your PRs and come up with a single PR? I have fairly limited time for reviews, so reviewing 4 versions of the same PR is not really practicable for me. Would be very nice if you get to a consensus on which is the most refined version that should be reviewed.

ianfab avatar Apr 04 '24 09:04 ianfab

I consider my version to be the most refined.

  • @alperatalayn initial version introduces basic structures to support musketeer variant , but breaks build and tests. Also it does not work.

  • @chris-heldeis version fixes some problems, but some tests still fail (at least it was so last week, and new commits don't contain anything relevant). Also Python and JS binding versions are incremented; I can't say if it is useful or not.

  • @sayantandey version: may be I'm not aware of some Github features, but in my opinion this version does not contain anything except @alperatalayn commits, so it's effectively empty.

  • @cross-of-north (mine) version - build and tests are all green, contains improvements/fixes to make the variant actually playable and compatible with GUI (Winboard) and with implementations in other engines.

cross-of-north avatar Apr 05 '24 05:04 cross-of-north

I consider my version to be the most refined.

  • @alperatalayn initial version introduces basic structures to support musketeer variant , but breaks build and tests. Also it does not work. ...
  • @sayantandey version: may be I'm not aware of some Github features, but in my opinion this version does not contain anything except @alperatalayn commits, so it's effectively empty.

My PR (as I mentioned in the name 'Fixes For#762 Pipeline fails') was to fix the build issues in the PR pipelnie from @alperatalayn version and make sure the windows distributables are successfully built and being able to run, I created the build to check the tests in PR pipeline (the make builds are already tested in my local) after fixing those issue. So, yes you can ignore my PR considering this.

sayantandey avatar Apr 05 '24 06:04 sayantandey