SODA-for-SPARC
SODA-for-SPARC copied to clipboard
codespell: config, workflow + fixing typos
please review. I spotted which might affect (fix) functioning: visbility
Thank you for submitting this pull request! We appreciate your contribution to the project. Before we can merge it, we need to review the changes you've made to ensure they align with our code standards and meet the requirements of the project. We'll get back to you as soon as we can with feedback. Thanks again!
Sourcery Code Quality Report
Merging this PR leaves code quality unchanged.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 68.91 ⛔ | 68.91 ⛔ | 0.00 |
Method Length | 167.25 😞 | 167.25 😞 | 0.00 |
Working memory | 5.65 ⭐ | 5.65 ⭐ | 0.00 |
Quality | 27.42% 😞 | 27.42% 😞 | 0.00% |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 9911 | 9911 | 0 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
docs/test-dataset/code/adjusted-code.py | 14.80% ⛔ | 14.80% ⛔ | 0.00% |
pyflask/curate/curate.py | 12.59% ⛔ | 12.59% ⛔ | 0.00% |
pyflask/disseminate/disseminate.py | 72.89% 🙂 | 72.89% 🙂 | 0.00% |
pyflask/manageDatasets/manage_datasets.py | 50.27% 🙂 | 50.27% 🙂 | 0.00% |
pyflask/manifest/manifest_builder.py | 83.94% ⭐ | 83.94% ⭐ | 0.00% |
pyflask/manifest/manifest_writer.py | 27.14% 😞 | 27.14% 😞 | 0.00% |
pyflask/namespaces/configureNamespaces.py | 79.55% ⭐ | 79.55% ⭐ | 0.00% |
pyflask/prepareMetadata/prepare_metadata.py | 54.00% 🙂 | 54.00% 🙂 | 0.00% |
tools/soda-json-structure/soda-sparc-structure.py | 57.62% 🙂 | 57.62% 🙂 | 0.00% |
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
---|---|---|---|---|---|---|
pyflask/curate/curate.py | bf_generate_new_dataset | 248 ⛔ | 2033 ⛔ | 0.00% ⛔ | Refactor to reduce nesting. Try splitting into smaller methods | |
docs/test-dataset/code/adjusted-code.py | bf_generate_new_dataset | 248 ⛔ | 1161 ⛔ | 0.00% ⛔ | Refactor to reduce nesting. Try splitting into smaller methods | |
pyflask/curate/curate.py | create_high_level_manifest_files_existing_bf | 188 ⛔ | 1455 ⛔ | 0.00% ⛔ | Refactor to reduce nesting. Try splitting into smaller methods | |
docs/test-dataset/code/adjusted-code.py | create_high_level_manifest_files_existing_bf | 186 ⛔ | 1204 ⛔ | 0.00% ⛔ | Refactor to reduce nesting. Try splitting into smaller methods | |
docs/test-dataset/code/adjusted-code.py | bf_update_existing_dataset | 125 ⛔ | 887 ⛔ | 0.07% ⛔ | Refactor to reduce nesting. Try splitting into smaller methods |
Legend and Explanation
The emojis denote the absolute quality of the code:
- ⭐ excellent
- 🙂 good
- 😞 poor
- ⛔ very poor
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
ping! if I put in effort to update this PR, would it be reviewed/considered? ;)
ping @bvhpatel and @aaronm-2112 to guide me on this PR -- if not desired, just say so
This PR has been merged via the attached commit 01b9789. Thanks for the contribution and our apologies for the communication delay.
Thanks for closing this pull request! If you have any further questions, please feel free to open a new issue. We are always happy to help!