graph-prototype icon indicating copy to clipboard operation
graph-prototype copied to clipboard

[3pt] graph-prototype: Consolidate UT-based tests and test applications

Open ivan-cukic opened this issue 1 year ago • 2 comments

There is a lot of copy-paste code in the tests. Especially in the separate applications (test/app_*.cpp). The reason for the current test applications are issues with uT.

ivan-cukic avatar Jun 21 '23 15:06 ivan-cukic

This is likely linked and/or could be combined with: https://github.com/fair-acc/opendigitizer/issues/91

@wirew0rm, what do you think?

RalphSteinhagen avatar Jul 15 '23 10:07 RalphSteinhagen

I think it's more related to #125 at least from the title?

Sounds like we have to either fix the issues with UT (mentioned issue) or add some light abstractions to reuse code between ut tests and test apps (this issue). The block refactoring tackles another kind of duplication? There is some overlap in in the files this touches, but conceptually the issues are different and #91 is simple refactoring while this one needs investigation and possibly fixes on the UT side, so I think it's easier to leave them separate for now. (Always possible to fix both in a single PR)

wirew0rm avatar Jul 17 '23 17:07 wirew0rm

done.

RalphSteinhagen avatar May 28 '24 19:05 RalphSteinhagen