graph-prototype icon indicating copy to clipboard operation
graph-prototype copied to clipboard

blocks/Math: porting the math block-family ( + vast and edge tests)

Open KrxGu opened this issue 7 months ago • 2 comments

75% of MATH headers were ported and are now compiling/building under GR-4 (AddConst, SubtractConst, MultiplyConst, DivideConst, Add, Subtract, Multiply, Divide, Max, Min, And, Or, Xor, Negate, Not, Abs, Integrate, Argmax. ) Along with their vast test cases. Tried my best to keep it optimized and minimal so that we don't need many templates for header files.

KrxGu avatar Jun 06 '25 20:06 KrxGu

I think the code is in good shape, but we need to get the CI jobs passing now. Look compiler errors.

jsallay avatar Jun 11 '25 10:06 jsallay

@KrxGu

image

Please rebase and bump.

Also, please keep the code together, structured and as concise as possible. Splitting the math header files isn't a good optimisation. See my other comments above. You are nearly there ...

RalphSteinhagen avatar Jun 24 '25 05:06 RalphSteinhagen