pixel icon indicating copy to clipboard operation
pixel copied to clipboard

Published 20 hours ago • verified publisher icon faiface

Curves

Open jakubDoka opened this issue 4 years ago • 6 comments

This commit adds beizer curves to geometry and also adds one method for vector Angle to. Its all documentated. Curve should be used by a particle system i am planing to pull request.

jakubDoka avatar Nov 04 '20 20:11 jakubDoka

Why no tests?

Not sure why you're returning a pointer for B, Linear or Constant and why you have a pointer receiver for Point, the rest of the file is entirely functional with no pointer returns or receivers

bcvery1 avatar Nov 04 '20 22:11 bcvery1

Ok i ll make some test just for sake of it. Lets remove these pointers then.

jakubDoka avatar Nov 05 '20 17:11 jakubDoka

The Bezier functions/structures look good, was there a reason why you needed to change the pixelgl.Window structure to directly embed the glfh.Window structure?

@jakubDoka

dusk125 avatar Aug 31 '21 13:08 dusk125

@dusk125

I assume this PR is not relevant anymore.

duysqubix avatar Oct 02 '23 19:10 duysqubix

@duysqubix could still be useful, I would suggest we revert the window.go changes. But other than those, lgtm

dusk125 avatar Oct 04 '23 15:10 dusk125

@dusk125

I am going to recreate this PR in pixel2 to track and modify changes there.

Update: PR merged with Pixel2

duysqubix avatar Oct 04 '23 15:10 duysqubix