Fabian Boehm
Fabian Boehm
Note: This not only reduces our dependency on cmake, but is also needed to be able to test self-installable fish - because that doesn't use cmake.
> Would it be useful if fish_test_helper were written in Rust? Not really. We require a c compiler to compile anyway - libc.c, the rsconf checks. I also don't know...
> cargo install already installs all three binaries, right? That's right, and this doesn't change it. We *could* remove one or both of them in future if we go through...
Also: This gives us the opportunity to rename `fish_indent`. We could call it `fishfmt`, given that it does a bunch more than indentation, and for consistency with `cargo fmt` and...
> Renaming would be great (also underscores are odd, I'd rather use "-" or no separator). If we did rename, I would want it to be more substantial change than...
An alternative is to replace `fish_indent` with an option to the main fish binary - `fish --format`. This would make it easier to call from the outside if you don't...
I've decided to merge this now so we can get some experience in. There are improvements to be made, but it's already useful.
> I'm not sure the opposite makes sense (set --default -g foo stealing a value from a local foo). I mean if you have a local variable, you're gonna know...
Okay, it appears there's no consensus here and I do not currently have the bandwidth to work on it, closing.
A failure from 06.01.2025 on Alpine (Cirrus): ``` Testing file checks/tmux-job.fish ... Failure: The CHECK on line 16 wants: {{.*}} world which failed to match line stdout:4: prompt 0> echo...