fahed dorgaa comments

Results 135 comments of


                                            fahed dorgaa

support PostExit Hook

> > @AkihiroSuda would please give me more details about `exec(2)-ing the container process` or may be link code or article around this. I am looking for an entrypoint to...

support PostExit Hook

opened ticket https://github.com/containerd/containerd/issues/8163

`failed to attach to the container: failed to open stdout fifo: error creating fifo binary:///usr/local/bin/nerdctl?_NERDCTL_INTERNAL_LOGGING=%2Fvar%2Flib%2Fnerdctl%2F1935db59: no such file or directory`

> Is this change compatible with `nerdctl logs`? > > My understanding is that when a container is launched with `-d` flag, the `stdout` and `stderr` streams will be forwarded...

`failed to attach to the container: failed to open stdout fifo: error creating fifo binary:///usr/local/bin/nerdctl?_NERDCTL_INTERNAL_LOGGING=%2Fvar%2Flib%2Fnerdctl%2F1935db59: no such file or directory`

> The same dual logging approach we have for non-detached mode may not be viable here and we might need to come up with an alternate solution. agree. Apparently, the...

Let's refactor the nerdctl CLI package

Welcome back @Zheaoli 👋, > I agree each command should have a CommandOption struct, regardless small or large. We should put them in a separate pkg (e.g., api/types.go, or pkg/api/types.go)....

Let's refactor the nerdctl CLI package

@arnaldo2792 > I want to help with this, but I'm confused with the current state. Are the items that are not checked available for grabs? ❓ not sure but you...

Does `nerdctl restart` have unstable issues

It is not possible to restart stopped container. You just need to make start hete

/usr/bin/nerdctl _NERDCTL_INTERNAL_LOGGING process consumes lots of file description

``` if we dont want to use [nerdctl logs] cmd，cannot we deploy the process _NERDCTL_INTERNAL_LOGGING ``` not possible as `/proc/self/exec _NERDCTL_INTERNAL_LOGGING` is used to read and write logs

Publishing of ports does not work on container restart. (`msg="conflict with ID 7"`)

> > Stop the running container by pressing CTRL+C. > > The container has to be removed, not just stopped @AkihiroSuda you think that the new running container is conflicting...

fix: Add used port check for publish flag

> > Test failed https://github.com/containerd/nerdctl/actions/runs/4814951537/jobs/8573169644?pr=2190#step:6:982 > > ``` > > time="2023-04-27T01:30:38Z" level=fatal msg="failed to load networking flags: bind for :8080 failed: port is already allocated" > > ``` > >...