Jacob Gadikian
Jacob Gadikian
Proposal: we make addvote its own file. state.go is >2000 lines long
## using all linters will create a house of pain because they conflict with one another. I know this because I've tried to do it before. The key linter in...
Here's perfsprint: * https://github.com/cometbft/cometbft/pull/2287
Here's what goerr113 would do: ``` internal/state/indexer/sink/psql/psql_test.go:291:10: err113: do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf(\"dropping tables: %v\", err)" (goerr113) return fmt.Errorf("dropping tables: %v", err) ^ internal/state/indexer/sink/psql/psql_test.go:295:10:...
@AbhinavMir - hey, so, basically, right now we have all of the linters enabled in .golangci.yml. The ones that are not enabled are listed like this: ```yaml run: tests: true...
I'd like to request it this issue be closed if we're not serious about pursuing it. The revive inter PR has been open for months now, and it resolves most...
Hey @adizere @melekes @cason I need to ask for some help here. 180 seconds doesn't work, and I can log the block differences, but, I think we could have a...
@cason this sounds to me like the scary place where p2p meets consensus.
@cason interesting...... eg: very interesting problem Don't quite know the solution.
> But regarding this test, specifically, I wonder why it covers Prevote votes. Indeed sir As a validator, I do know that prevotes, on some level, do indeed count for...