google-play-scraper Fix app details mapping for asian countries

Fix app details mapping for asian countries

Open knirpsfass opened this issue 2 years ago • 5 comments

This PR fixes mapping of app details with the help of the service request id

DRAFT because tests are missing and
mapping for

familyGenre: ['ds:5', 0, 12, 13, 1, 0],
familyGenreId: ['ds:5', 0, 12, 13, 1, 2],

Jul 05 '22 13:07 knirpsfass

Does anyone know what the familyGenre or familyGenreId is. I can't find an app that contains it

Jul 05 '22 18:07 knirpsfass

Thanks for the fix! This may be a good test that makes the library's current version crash, and is fixed with this PR:

id: "com.squaretrade.personalcloud",
country: "au"

Jul 09 '22 07:07 mmoksh

What's the status of this PR?

Jul 18 '22 13:07 facundoolano

What's the status of this PR?

Maybe I'll be able to implement the suggested changes this weekend otherwise upcoming weekend

Jul 18 '22 17:07 knirpsfass

cool, no hurry on my side, just wanted to make sure you weren't waiting on me.

Jul 18 '22 17:07 facundoolano

closing this since meanwhile #583 fixed the issue

Aug 22 '22 20:08 knirpsfass