feedi icon indicating copy to clipboard operation
feedi copied to clipboard

Locked out of feed edit page when using '/' in name

Open morganridel opened this issue 1 year ago • 1 comments
trafficstars

Hello, nice project!

I'm trying it out for myself and it seems that using a '/' character in a feed name prevent access to any url using the feed name. I know bugs should be expected, I'm sharing it just in case.

image

STRs:

  • Add the feed https://www.reddit.com/r/selfhosted/top.rss with name /r/selfhosted
  • Get a 404 on the resulting /feeds//r/selfhosted/entries page
  • Can't access or delete the feed afterwards

I had to manually edit the sqlite database to fix this.

I guess you could disallow forward slashes or maybe url-encode them?

morganridel avatar Dec 18 '23 14:12 morganridel

Thanks for reporting.

I guess you could disallow forward slashes or maybe url-encode them?

Yes I should do one of things things. There's the alternative of not using names in the urls, but at least for the filtering I think it's desirable to have it displayed in the url (arguably the same could be done by using id + slug).

A related set of bugs happens with using spaces in the names, that should also be handled.

facundoolano avatar Dec 18 '23 14:12 facundoolano