angular-unsavedChanges icon indicating copy to clipboard operation
angular-unsavedChanges copied to clipboard

Published 20 hours ago • verified publisher icon facultymatt

bower.json incorrect main path

Open sabrehagen opened this issue 9 years ago • 9 comments

The main property in your bower.json incorrectly refers to unsavedChanges.js rather than dist/unsavedChanges.js. This breaks tools like wiredep. Can you please update your main path to reflect the correct path to the source?

sabrehagen avatar May 16 '15 09:05 sabrehagen

@sabrehagen same problem here. Do you know any way to fix that?

adamkarb avatar Jun 24 '15 19:06 adamkarb

I have been manually editing my local copy of the repo, but it needs to be done every time you do a fresh bower install which is annoying. We could submit a pull request, but there are outstanding pull requests that have already been waiting for months, so the likelihood of it getting accepted is low. You could always fork your own copy, edit it there, and bower install from your repo; that's the best solution.

sabrehagen avatar Jun 24 '15 22:06 sabrehagen

Yea that sounds fair, but I will probably just do something on my own. This guy seems to have skipped town.

adamkarb avatar Jun 25 '15 13:06 adamkarb

This seems to be fixed in your repository. Can you please publish it to npm?

sabrehagen avatar Aug 14 '15 06:08 sabrehagen

@sabrehagen Could you go ahead and do a pull request just so others that see it may find it useful to merge into their own repos.

Additionally, I would recommend mentioning facultymatt when creating issues and pull requests so he is sure to be notified.

Stargator avatar Nov 03 '15 16:11 Stargator

Another fix is to use wiredep's "overrides" property to set the correct path for the bower.json "main".

adamkarb avatar Nov 04 '15 14:11 adamkarb

@Stargator it's fixed in this repo, so if you clone the repo it will work, but (presumably) we're all using npm where the package hasn't been updated with the latest source from the repo.

sabrehagen avatar Nov 05 '15 00:11 sabrehagen

I'm just using bower and it still has this problem. Does anybody have a working fork? I mean, it works on my machine, but if I commit this code, it will break everyone on the team's app, as well as the development server...

EDIT: Hey, got it! Just specify a version in the command line. The latest version, as of this comment, is 0.2.3-alpha.3. So I just said this at the command line:

bower install angular-unsavedChanges#0.2.3-alpha.3 --save

vbullinger avatar Mar 21 '16 21:03 vbullinger

Use the github repo in your bower file as the repo has the correct path, what's installed by bower is out of date. On 22 Mar 2016 8:22 am, Vince Bullinger [email protected] wrote:I'm just using bower and it still has this problem. Does anybody have a working fork?

—You are receiving this because you were mentioned.Reply to this email directly or view it on GitHub

sabrehagen avatar Mar 22 '16 00:03 sabrehagen