PlotJuggler icon indicating copy to clipboard operation
PlotJuggler copied to clipboard

Improve CSV loader error handling

Open Bartimaeus- opened this issue 3 years ago • 0 comments

Summary

  • Allow PlotJuggler to load CSV files with non-monotonic data with a warning (data is sorted to be monotonic) instead of aborting
  • Improvements to error handling dialogs with additional information

Handling Non-Monotonic data The csv loader would reject csv files that didn't have the data sorted strictly monotonically and would abort loading the file if this was detected. This isn't necessary as the push_back() function used to add the data in the TimeseriesBase class already detects this and inserts new values into the correct place. Since non-monotonic time might be unexpected by the user this change brings up a dialog window where the user can choose to abort or continue with extra information that can be viewed:

image

Other Improvements These are mostly quality of life improvements. I got tired of having to switch between PlotJuggler and my csv file trying to figure out where the issue was. Examples of the other dialog windows: image

Failed to parse timestamp: image

Bartimaeus- avatar Aug 09 '22 23:08 Bartimaeus-

Missing a parenthesis from that last tweak, I will fix tomorrow

Bartimaeus- avatar Aug 11 '22 04:08 Bartimaeus-

Fixed

Bartimaeus- avatar Aug 12 '22 02:08 Bartimaeus-

Thanks a lot

facontidavide avatar Aug 12 '22 03:08 facontidavide