paraunit icon indicating copy to clipboard operation
paraunit copied to clipboard

PHP 8.5

Open Jean85 opened this issue 4 months ago • 3 comments

~Tries to fix #326~ Adds CI job to test under PHP 8.5

Jean85 avatar Aug 15 '25 15:08 Jean85

@keradus as you can see, my CI is green even under PHP 8.5: https://github.com/facile-it/paraunit/actions/runs/16993356550/job/48177975461?pr=327

So, I cannot reproduce any issue here, and I do not see any issue specific of Paraunit in your failed test run here: https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/actions/runs/16950052409/job/48040517434

Let me know if you're able to restrict the issue to a small reproducer.

Jean85 avatar Aug 15 '25 16:08 Jean85

i failed to identify smaller reprocase other than PHPUnit passing on CI and ParaUnit failing on CI under 8.5. both passing under older PHP. if you up for it, feel welcome to experiment directly in our repo CI via kind-of-debugging PR.

if you not up for it, totally ok. i will keep paraunit disabled till root cause found

keradus avatar Aug 15 '25 20:08 keradus

Thanks to #328 it's now failing due to some deprecation inside Composer's vendor folder:

PHP Deprecated:  Case statements followed by a semicolon (;) are deprecated, use a colon (:) instead in phar:///usr/local/bin/composer/vendor/react/promise/src/functions.php on line 300

So it doesn't seem to have unearthed the real issue.

Jean85 avatar Aug 16 '25 09:08 Jean85