redux-first-router icon indicating copy to clipboard operation
redux-first-router copied to clipboard

Incompatible with history v5

Open miikka opened this issue 4 years ago • 1 comments

The documentation suggests using the history package. Recently version 5.0.0 was released and there was a bunch of documented and undocumented breaking changes. At least this one causes problems for me with redux-first-router 2.1.5:

  • history.listen() API changed. The callbacks are now called with an an object of shape Update instead of Location

For me, it causes error TypeError: Cannot read property 'toLowerCase' of undefined from connectRoutes.js.

Workarounds:

  • Keep using history 4.10.1
  • Use rudy-history instead. It seems to be what redux-first-router uses internally.

miikka avatar Jul 21 '20 09:07 miikka

Did you also have issues with location.search or location.query ? I am tracking down a bug now where those parameters seem to have disappeared, and I'm not sure if redux-first-router is to blame here, or if it's the history package

Alevale avatar May 01 '24 12:05 Alevale