babel-plugin-universal-import icon indicating copy to clipboard operation
babel-plugin-universal-import copied to clipboard

Published 20 hours ago • verified publisher icon faceyspacey

Typescript and non-Babel environments example out of sync with TypeScript definitions

Open corydeppen opened this issue 7 years ago • 3 comments

The universal options in the example (chunkName and resolve) don't exist in the current react-universal-component declaration file. Interestingly, the Flow types contain the properties, though.

Can this example be updated with the appropriate options that should be passed when used in a TypeScript project or can the TypeScript definitions for react-universal-component be updated to reflect the valid options?

/cc @forabi @Alex-Krautmann

corydeppen avatar Jan 03 '18 18:01 corydeppen

Any update?

rohmanhm avatar May 10 '18 00:05 rohmanhm

@corydeppen we had some TS defs updated. Does this solve your issue / would you be able to PR it?

I dont know much TS

ScriptedAlchemy avatar Sep 17 '18 23:09 ScriptedAlchemy

I believe it's resolved by https://github.com/faceyspacey/react-universal-component/pull/99 and this issue can be closed.

cdoublev avatar Aug 27 '20 06:08 cdoublev