xformers icon indicating copy to clipboard operation
xformers copied to clipboard

Add LRA to CI

Open dianaml0 opened this issue 2 years ago • 3 comments

🚀 Feature

Capturing idea from @blefaudeux here. Add LRA to the CI since some bugs are only showing up through manual runs of it. Should be a smaller version of the full LRA.

Motivation

LRA has caught many bugs, could be useful to add it to the continuous integration testing.

Pitch

LRA with a smaller dataset.

Alternatives

Limit tasks and attention variants to a subset. Run a benchmark in parallel not necessarily linked to CI

Additional context

https://github.com/facebookresearch/xformers/pull/145#issuecomment-996223858

dianaml0 avatar Dec 17 '21 03:12 dianaml0

I think that one plan could be to:

  • add minGPT like (pull shakespeare, autoregressive task) as an LRA task (same formalism as the others)
  • use that as a lightweight task on CI, over a couple of tokens, checking that some of the LRA codepath is in good shape

thoughts ?

blefaudeux avatar Dec 20 '21 16:12 blefaudeux

Yes that sounds like a good idea! Should we also have the full LRA run regularly as well not necessarily part of CI?

dianaml0 avatar Dec 20 '21 20:12 dianaml0

Yes agreed for the full LRA, but then probably on the Fair cluster with the framework built by Caleb Ho ?

blefaudeux avatar Dec 20 '21 20:12 blefaudeux