metaseq icon indicating copy to clipboard operation
metaseq copied to clipboard

Python version requirement more strict than stated

Open EIFY opened this issue 3 years ago • 1 comments

🐛 Bug

According to https://github.com/facebookresearch/metaseq/blob/c4b33ba6e2cd9b33539bbb5a35d831096bde3282/setup.py#L12-L13 Python >= 3.6 should be compatible. However, since TypedDict was introduced by https://github.com/facebookresearch/metaseq/pull/352, metaseq now effectively requires Python 3.8. Furthermore, since torch==1.10.1+cu113 doesn't support Python 3.10,

pip3 install torch==1.10.1+cu113 torchvision==0.11.2+cu113 torchaudio==0.10.1+cu113 -f https://download.pytorch.org/whl/cu113/torch_stable.html

no longer works for Python >= 3.10.

To Reproduce

Follow setup.md to install metaseq with python < 3.8 or >= 3.10.

Environment

  • metaseq Version: latest main (c4b33ba6e2cd9b33539bbb5a35d831096bde3282)
  • PyTorch Version: 1.10.1+cu113
  • OS (e.g., Linux): Ubuntu 18.04.6 LTS
  • How you installed metaseq: pip
  • Python version: 3.7, 3.10
  • CUDA/cuDNN version: CUDA 11.7
  • GPU models and configuration: 1 x T4

EIFY avatar Oct 04 '22 23:10 EIFY

FYI, specified branch of Megatron-LM

git clone --branch fairseq_v2 https://github.com/ngoyal2707/Megatron-LM.git

also no longer works with newer versions of PyTorch since the header file it wants to include #include <THC/THC.h> is gone.

EIFY avatar Oct 06 '22 18:10 EIFY