mbrl-lib icon indicating copy to clipboard operation
mbrl-lib copied to clipboard

[Feature Request] Support for Dreamers

Open veds12 opened this issue 2 years ago • 10 comments

🚀 Feature Request

Add support for Dreamer and Dreamerv2

Motivation

Dreamer and Dreamerv2 are important and current SOTA in mbrl. Few standard implementations are available for both Dreamer (rllib, author's implementation) and Dreamerv2 (author's implementation). Some good implementations include https://github.com/RajGhugare19/dreamerv2, https://github.com/juliusfrost/dreamer-pytorch and https://github.com/jurgisp/pydreamer

Pitch

Both Dreamer and Dreamerv2 can be written on top of planet

veds12 avatar Jan 18 '22 10:01 veds12

Hi @veds12. This is definitely at the top of my list of priorities for MBRL-Lib! I hope we can roll out an implementation in the next few months, but It's taking longer than I'd like since I have other commitments.

luisenp avatar Jan 18 '22 14:01 luisenp

I would be interested in contributing @luisenp. Long time been on my list to study it.

natolambert avatar Jan 18 '22 16:01 natolambert

Thank you @luisenp and @natolambert ! @natolambert I would be interested in this as well. Please let me know (if / how) I can help :)

veds12 avatar Jan 18 '22 17:01 veds12

That sounds great! How about setting a VC the 3 of us to coordinate this week? Does Friday work for you? If you are interested, send me an email and I'll send an invite to that address. @veds12 @natolambert

luisenp avatar Jan 18 '22 17:01 luisenp

Hi! Just wanted to check in on progress on this; I'd be interested in contributing as well.

Rohan138 avatar Apr 04 '22 19:04 Rohan138

Hi @Rohan138. @veds12 opened a PR skeleton for this (#145), but there hasn't been a lot of progress lately, and I've been busy with other projects. Contributions are definitely welcome! I will also have more time after NeurIPS deadline to offer support/collaborate on this :)

luisenp avatar Apr 04 '22 20:04 luisenp

@luisenp Just opened a draft PR #151 ; mainly need to debug and clean up the dreamer loss calculation, then test it.

Rohan138 avatar Jun 05 '22 06:06 Rohan138

Awesome! I'll take a look this week and give feedback. Thanks a lot for contributing to the library!

luisenp avatar Jun 05 '22 13:06 luisenp

#151

This PR is intended to implement DreamerV2?

ManuelRios18 avatar Jul 10 '22 20:07 ManuelRios18

Hi @ManuelRios18 that PR is intended to implement the original Dreamer.

luisenp avatar Jul 11 '22 12:07 luisenp