jepa icon indicating copy to clipboard operation
jepa copied to clipboard

Use projection in CrossAttention

Open Shade5 opened this issue 1 year ago • 5 comments

Shade5 avatar Feb 19 '24 22:02 Shade5

Hi @Shade5!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Feb 19 '24 22:02 facebook-github-bot

We do not use the bare cross-attention module by default, but this is a valid update. Please make sure to follow the steps in the CONTRIBUTING.MD to be able to merge your PR.

MidoAssran avatar Feb 19 '24 22:02 MidoAssran

@MidoAssran It's being used by AttentiveClassifier in evals/image_classification_frozen/eval.py

Shade5 avatar Feb 20 '24 01:02 Shade5

Yes that's correct, I just mean by default it is combined with a small MLP after the cross-attention. Please check off the Contributor License Agreement so that I can merge your PR.

MidoAssran avatar Feb 20 '24 15:02 MidoAssran

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Feb 20 '24 21:02 facebook-github-bot