habitat-sim icon indicating copy to clipboard operation
habitat-sim copied to clipboard

[Sensor][WIP] Python SensorSuite in each SceneNode

Open vauduong opened this issue 3 years ago • 1 comments

Motivation and Context

PR #1118 introduces SensorSuites in each SceneNode. In this PR:

  • Deprecate SensorSuite and Sensor wrapper in python simulator code
  • Note, this builds locally but not on ci, currently trying to debug

How Has This Been Tested

Run tests

Types of changes

  • [ ] Docs change / refactoring / dependency upgrade
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [ ] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have completed my CLA (see CONTRIBUTING)
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

vauduong avatar Mar 23 '21 01:03 vauduong

This changes some whitehot code in habitat_sim so we need to make sure this doesn't cause any serious performance regressions.

Skylion007 avatar Mar 23 '21 16:03 Skylion007