habitat-lab icon indicating copy to clipboard operation
habitat-lab copied to clipboard

Published 20 hours ago • verified publisher icon facebookresearch

Ant task fix

Open ScottCSteinhauser opened this issue 3 years ago • 2 comments

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [ ] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have completed my CLA (see CONTRIBUTING)
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

ScottCSteinhauser avatar Mar 01 '22 22:03 ScottCSteinhauser

@ScottCSteinhauser does this PR still makes sense? Can you provide more information for rational behind it? Thank you!

mathfac avatar Aug 30 '22 20:08 mathfac

@ScottCSteinhauser does this PR still makes sense? Can you provide more information for rational behind it? Thank you!

I don't think much of this is necessary to merge into main. However, it is worth noting the hacks which were necessary to get evaluation videos. Maybe some of this has since been addressed, but otherwise it represents a use case with some friction.

aclegg3 avatar Aug 31 '22 16:08 aclegg3

Unnecessary to leave this open, archiving.

aclegg3 avatar Feb 14 '23 19:02 aclegg3