faiss icon indicating copy to clipboard operation
faiss copied to clipboard

Patched to build on cuda12.4 on windows system

Open Sanjib-ac opened this issue 7 months ago • 4 comments

Patched files to support CUDA 12.4 on Windows. Also bypassed the OpenMP_CUDA requirement; a warning will be shown.

Sanjib-ac avatar Jul 25 '25 02:07 Sanjib-ac

Hi @Sanjib-ac!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Jul 25 '25 02:07 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Jul 25 '25 03:07 facebook-github-bot

The .cu and .cuh changes seem OK, but there are some format errors. Can you see the logs in https://github.com/facebookresearch/faiss/actions/runs/16512198656/job/46740224166?pr=4456 ?

mnorris11 avatar Jul 25 '25 18:07 mnorris11

@gtwang01 has imported this pull request. If you are a Meta employee, you can view this in D79108319.

facebook-github-bot avatar Jul 28 '25 18:07 facebook-github-bot

Hey @Sanjib-ac, can you take a look at this again? Maybe update it or close it if you're no longer working on it.

gtwang01 avatar Jan 06 '26 00:01 gtwang01

Hey @Sanjib-ac, can you take a look at this again? Maybe update it or close it if you're no longer working on it.

I’m not working on it anymore since it works fine on my side. However, I can take a look at where it’s failing, but the logs are no longer available.

Sanjib-ac avatar Jan 07 '26 15:01 Sanjib-ac