faiss icon indicating copy to clipboard operation
faiss copied to clipboard

Support cuda 12.4 in conda

Open pankajsingh88 opened this issue 1 year ago • 1 comments

Original request: https://github.com/facebookresearch/faiss/issues/3995 which was wrongly transferred to discussion.

Discussed in https://github.com/facebookresearch/faiss/discussions/3996

Originally posted by hiyyg October 28, 2024

Summary

Platform

OS:

Faiss version:

Installed from:

Faiss compilation options:

Running on:

  • [x] CPU
  • [x] GPU

Interface:

  • [ ] C++
  • [x] Python

Reproduction instructions

pankajsingh88 avatar Oct 28 '24 19:10 pankajsingh88

Since pytorch now supports 12.4 by default, I think it is worth supporting cuda 12.4 for faiss.

hiyyg avatar Oct 30 '24 03:10 hiyyg

Any update on this? I know it's a bit minor but 12.4 is already no longer the latest release.

rileyseaburg avatar Jan 10 '25 17:01 rileyseaburg

+1

melissa-pan avatar Mar 05 '25 17:03 melissa-pan

+1

faiss-gpu is not working for me on lambda cloud a100 CUDA12.4

yudataguy avatar Mar 05 '25 22:03 yudataguy

+1

zhiqihuang avatar Mar 27 '25 13:03 zhiqihuang

resolve with using faiss-gpu-cuvs

liuyixin-louis avatar Apr 17 '25 04:04 liuyixin-louis

windows, cuda12.4, c++

Sanjib-ac avatar Jul 11 '25 12:07 Sanjib-ac

cuda1.24 support needed

So-cean avatar Jul 17 '25 08:07 So-cean

I see from build logs that recent cmake builds are using cuda 12.4 already: https://github.com/facebookresearch/faiss/actions/runs/16504152774/job/46671550027

I am trying to add a nightly that publishes a conda package for 12.4 in https://github.com/facebookresearch/faiss/pull/4442.

mnorris11 avatar Jul 24 '25 21:07 mnorris11

I did build too using cuda12.4 on windowns10, but needed patch a couple of files. It needs cleanup for windows supports.

Sanjib-ac avatar Jul 24 '25 21:07 Sanjib-ac

I did build too using cuda12.4 on windowns10, but needed patch a couple of files. It needs cleanup for windows supports.

We don't have a conda build publishing CUDA + windows, but feel free to submit a patch for those files. If it passes for other CI, we can merge it.

mnorris11 avatar Jul 24 '25 22:07 mnorris11

@mnorris11 Done!

Sanjib-ac avatar Jul 25 '25 02:07 Sanjib-ac

Merged the nightly.yml change for CUDA 12.4 in https://github.com/facebookresearch/faiss/pull/4442, will monitor nightly

mnorris11 avatar Jul 25 '25 18:07 mnorris11

Nightly for Faiss GPU (without cuVS) is succeeding on CUDA 12.4. https://github.com/facebookresearch/faiss/actions/runs/16588259378/job/46917790343

Please let us know if you have issues.

mnorris11 avatar Jul 29 '25 15:07 mnorris11