faiss icon indicating copy to clipboard operation
faiss copied to clipboard

add test for external modules

Open mdouze opened this issue 1 year ago • 7 comments

Summary: External modules should work fine as plug-ins to Faiss in the following cases:

  • additional objects that can be passed in as callbacks to Faiss

  • functions that use faiss.swig_ptr to pass in arrays.

The swig_ptr functionality does not always work well (also depending on the platform). Therefore this diff adds a small external swig file to test that everything works smoothly on that end.

Differential Revision: D60379753

mdouze avatar Jul 29 '24 12:07 mdouze

This pull request was exported from Phabricator. Differential Revision: D60379753

facebook-github-bot avatar Jul 29 '24 12:07 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D60379753

facebook-github-bot avatar Jul 29 '24 12:07 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D60379753

facebook-github-bot avatar Aug 30 '24 07:08 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D60379753

facebook-github-bot avatar Oct 01 '24 06:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D60379753

facebook-github-bot avatar Oct 01 '24 09:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D60379753

facebook-github-bot avatar Oct 02 '24 14:10 facebook-github-bot

Hi @mdouze should we close this one since it is merged in https://github.com/facebookresearch/faiss/pull/3981 ?

mnorris11 avatar Oct 28 '24 20:10 mnorris11