faiss icon indicating copy to clipboard operation
faiss copied to clipboard

Feature request: arm64 win support

Open davidmatson opened this issue 2 years ago • 6 comments
trafficstars

We're currently using faiss on arm64 on Windows, but we can't use the main branch as-is for that.

davidmatson avatar Jul 27 '23 21:07 davidmatson

Have you tried to compile it by hand?

mdouze avatar Jul 29 '23 06:07 mdouze

Yes, I think so. We currently get it compiling by patching in edits from this branch: https://github.com/es0m/faiss/tree/user/es0m/support-win-arm-builds (if that's what you mean by "by hand"; I may have misunderstood)

davidmatson avatar Jul 31 '23 20:07 davidmatson

Yes sure. So IIUC the only change in the C++ part is in platform_macros.h I think we are not going to include it the CircleCI contiuous intergation but we can accept this patch so that people can compile for arm64 windows themselves.

mdouze avatar Aug 01 '23 11:08 mdouze

@mdouze - that would be great, thanks!

Yeah, I think the CircleCI part is a separate question. We consume via vcpkg, so if we could get whatever of the C++ & CMake parts needed so that it will "just work" for vcpkg consumers on Windows, that would be great.

davidmatson avatar Aug 01 '23 19:08 davidmatson

@algoriddle what do you think about the cmake patch ?

mdouze avatar Aug 03 '23 07:08 mdouze

@mdouze - that would be great, thanks!

Yeah, I think the CircleCI part is a separate question. We consume via vcpkg, so if we could get whatever of the C++ & CMake parts needed so that it will "just work" for vcpkg consumers on Windows, that would be great.

yes, I try to build, it fail, anyone will help me?

shijunz avatar Sep 05 '24 09:09 shijunz