faiss icon indicating copy to clipboard operation
faiss copied to clipboard

remove feature for GpuIndexIVFPQ, but not support interleaved layout

Open lailifeng-st opened this issue 2 years ago • 5 comments

Remove feature for GpuIndexIVFPQ, but not support interleaved layout. Unit tests are written in the upper-level application, so PR is not included.

lailifeng-st avatar Sep 02 '22 07:09 lailifeng-st

Please add a test to see if the functionality works, in the lines of

https://github.com/facebookresearch/faiss/blob/c0052c15336a57f7068a7d098d5ce5b6234a2d70/tests/test_index_composite.py#L72

(preferably in Python to test the whole stack)

mdouze avatar Sep 05 '22 13:09 mdouze

Please add a test to see if the functionality works, in the lines of

https://github.com/facebookresearch/faiss/blob/c0052c15336a57f7068a7d098d5ce5b6234a2d70/tests/test_index_composite.py#L72

(preferably in Python to test the whole stack)

Please add a test to see if the functionality works, in the lines of

https://github.com/facebookresearch/faiss/blob/c0052c15336a57f7068a7d098d5ce5b6234a2d70/tests/test_index_composite.py#L72

(preferably in Python to test the whole stack)

ok

lailifeng-st avatar Sep 06 '22 03:09 lailifeng-st

Please add a test to see if the functionality works, in the lines of

https://github.com/facebookresearch/faiss/blob/c0052c15336a57f7068a7d098d5ce5b6234a2d70/tests/test_index_composite.py#L72

(preferably in Python to test the whole stack)

Last week, the python environment was set up, but the " recipe for target' swigfaiss' failed " problem could not be solved, so I wrote the unit test to gpu/test/TestGpuIndexIVFPQ.cpp, and fixed the bugs found in the test. thanks

lailifeng-st avatar Sep 12 '22 04:09 lailifeng-st

To compile the python version, please follow the steps lined out in

https://github.com/facebookresearch/faiss/blob/main/.circleci/config.yml#L222

mdouze avatar Sep 12 '22 09:09 mdouze

To compile the python version, please follow the steps lined out in

https://github.com/facebookresearch/faiss/blob/main/.circleci/config.yml#L222

thanks, maybe I will try later

lailifeng-st avatar Sep 13 '22 07:09 lailifeng-st

Closing this stale PR as we expect the removal pattern to be satisfied by filtering followed by compaction in most ANN applications.

asadoughi avatar Jul 09 '24 18:07 asadoughi