fairseq
fairseq copied to clipboard
facebookresearch
Python 3.11 integration
Before submitting
- [x] Was this discussed/approved via a Github issue? (no need for typos, doc improvements) Yes this was, bug issue #5012
- [x] Did you read the contributor guideline? Yes
- [x] Did you make sure to update the docs?
- There was no need
- [ ] Did you write any new necessary tests?
- Further amendments need to be done to the Hydra library. Working on it at the moment.
What does this PR do?
Fixes # (5012).
PR review
Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Hi @Medoalmasry!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Unfortunately, after these changes, fireseq becomes incompatible with hydra. You do not know how to fix this problem? I also have python 3.11.
On image: caused by an exception in file hydra\core\config_store.py
hydra
Which warehouse are you referring to hydra? Is https://pypi.org/project/hydra-core?
