fairseq icon indicating copy to clipboard operation
fairseq copied to clipboard

skipping invalid sized validation set

Open shuvohishab opened this issue 2 years ago • 2 comments

Before submitting

  • [ ] Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • [x] Did you read the contributor guideline?
  • [x] Did you make sure to update the docs?
  • [ ] Did you write any new necessary tests?

What does this PR do?

Fixes # (issue). Even though skip_invalid_size_inputs_valid_test was set to true, validation data samples with a length exceeding max_tokens are being taken. In fact, the entire validation data was taken into account, as opposed to skip the longer length samples. This PR will resolve the issue. It will choose just those samples whose length is shorter than the 'max_tokens' value.

PR review

Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

shuvohishab avatar Oct 16 '22 11:10 shuvohishab

Hi @shuvohishab!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Oct 19 '22 07:10 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Oct 19 '22 09:10 facebook-github-bot