fairseq icon indicating copy to clipboard operation
fairseq copied to clipboard

Update prep_mtedx_data.py

Open bofenghuang opened this issue 2 years ago • 3 comments

Hi, missing unpacked value here :)

cc: @kahne

bofenghuang avatar Sep 13 '22 21:09 bofenghuang

Hi @bofenghuang!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Sep 13 '22 21:09 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Sep 13 '22 22:09 facebook-github-bot

Hi again @kahne ,

soundfile.write accepts an array of (T x C), but _wavform here has (C x T). Fixed here in 2nd commit

bofenghuang avatar Sep 13 '22 22:09 bofenghuang

Hi, is_audio arg has been added to get_zip_manifest for audio/fbanck in the 3rd commit

bofenghuang avatar Sep 14 '22 10:09 bofenghuang

Close as mentioned in https://github.com/facebookresearch/fairseq/issues/4493

bofenghuang avatar Nov 15 '22 21:11 bofenghuang