fairseq icon indicating copy to clipboard operation
fairseq copied to clipboard

Add parameter '--eval-sacrebleu-args' for translation task and re-fix #4689.

Open BrightXiaoHan opened this issue 3 years ago • 1 comments

Before submitting

  • [x] Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • [x] Did you read the contributor guideline?
  • [ ] Did you make sure to update the docs?
  • [ ] Did you write any new necessary tests?

What does this PR do?

Fixes #4690 and #4689.

PR review

Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

BrightXiaoHan avatar Sep 08 '22 08:09 BrightXiaoHan

Hi, @gwenzek, could you please help me review this PR?

BrightXiaoHan avatar Oct 09 '22 01:10 BrightXiaoHan