fairseq icon indicating copy to clipboard operation
fairseq copied to clipboard

honor dataset-impl option

Open mgaido91 opened this issue 1 year ago • 2 comments

Before submitting

  • [ ] Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • [ ] Did you read the contributor guideline?
  • [ ] Did you make sure to update the docs?
  • [ ] Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

mgaido91 avatar Jul 15 '22 00:07 mgaido91

cc @yuntang

mgaido91 avatar Jul 15 '22 00:07 mgaido91

It looks good to me!

yuntang avatar Jul 19 '22 00:07 yuntang