fairseq icon indicating copy to clipboard operation
fairseq copied to clipboard

Lightning App example for nllb (coming soon)

Open williamFalcon opened this issue 1 year ago • 3 comments

@myleott @alexeib amazing work once again! Would love to collaborate with you guys to build a Lightning App (a new class available in Lightning) so people can your work as a template for ML systems they might want to build. (here's an example of a Lightning App with OpenAI Clip to show how to build a meaningful ML system end-to-end)

Before submitting

  • [ ] Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • [ ] Did you read the contributor guideline?
  • [ ] Did you make sure to update the docs?
  • [ ] Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

williamFalcon avatar Jul 06 '22 20:07 williamFalcon

Hi @williamFalcon!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Jul 06 '22 20:07 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Jul 06 '22 20:07 facebook-github-bot

Hey @williamFalcon, thanks for the proposal! I am already in touch with Thomas (Chaton) and once we have an early release of fairseq v2, we can definitely consider having a demo Lightning App. You can check out our v2 announcement in #4493.

On the organizational side I recently transitioned from PyTorch to FAIR and right now leading our fairseq modernization effort. @alexeib is also pretty much involved in the project. Unfortunately @myleott is not at Meta anymore, but he is obviously more than welcome to contribute to the project anytime he wants.

cbalioglu avatar Jul 06 '22 20:07 cbalioglu