co-tracker icon indicating copy to clipboard operation
co-tracker copied to clipboard

Fix bug in resuming-from-checkpoint not working with mixed precision training

Open m43 opened this issue 1 year ago • 2 comments

Without the commit, resuming training from a checkpoint would induce a disruption in loss/accuracy curves, as is the case for the orange line from step 300. With this commit, the state_dict for the gradient scaler would also be saved into the checkpoint. This gives the dark blue curve that correctly resume from where the previous training left off. This only affects training and checkpoints that used mixed precision. image

m43 avatar Aug 15 '24 08:08 m43

Hi @m43!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Aug 15 '24 08:08 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Aug 15 '24 09:08 facebook-github-bot