beanmachine icon indicating copy to clipboard operation
beanmachine copied to clipboard

Point stat choice

Open ndmlny-qs opened this issue 1 year ago • 2 comments

Resolves #1817

Motivation

Allow a user to select which point statistic they want displayed in the Marginal 1D tool: mean or median.

Changes proposed

  • Added method to calculate the median of an array in JavaScript.
  • Updated the Marginal 1D tool to use the new method.
  • Updated the Marginal 1D interfaces to include a new widget component.
  • Updated the Python side of the tool to render the new widget.
  • Updated Python TypedDict objects to include docstrings for inclusion in the documentation in the future.
  • Updated the coin flipping tutorial to use the new point statistic button.

Test Plan

  • Updated the coin flipping tutorial, and visually inspected the tool worked.
  • Built the documentation locally for testing the new docstrings in Sphinx.
  • Built the Docusaurus documentation locally to ensure the new widgets worked.

new-widget-check.webm

Types of changes

  • [ ] Docs change / refactoring / dependency upgrade
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.
  • [x] The title of my pull request is a short description of the requested changes.

ndmlny-qs avatar Nov 07 '22 22:11 ndmlny-qs

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

add the Continuous Ranked Probability Score stat as well

ndmlny-qs avatar Nov 08 '22 18:11 ndmlny-qs