beanmachine icon indicating copy to clipboard operation
beanmachine copied to clipboard

Adds motivating example to RobustRegression notebook

Open zaxtax opened this issue 2 years ago • 12 comments

Motivation

This uses scikit-learn to show what happens when a regular regression is used and motivates the need for robustness in some examples with a plot.

Changes proposed

Adds some code to fit a regression using scikit-learn and an additional plot

Types of changes

  • [x] Docs change / refactoring / dependency upgrade
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [x] My code follows the code style of this project.
  • [x] My change requires a change to the documentation.
  • [x] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.
  • [ ] The title of my pull request is a short description of the requested changes.

zaxtax avatar Apr 29 '22 11:04 zaxtax

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@feynmanliang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Apr 29 '22 16:04 facebook-github-bot

I think the documentation GH action error may be related to bokeh plots?

feynmanliang avatar Apr 29 '22 16:04 feynmanliang

@zaxtax has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Apr 29 '22 18:04 facebook-github-bot

The problem should be resolved now. See the commit notes outlining the resolution.

ndmlny-qs avatar Apr 29 '22 20:04 ndmlny-qs

@feynmanliang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 03 '22 00:05 facebook-github-bot

@zaxtax has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar May 03 '22 00:05 facebook-github-bot

@zaxtax has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar May 03 '22 02:05 facebook-github-bot

@feynmanliang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 05 '22 20:05 facebook-github-bot

Can you rebase this please?

feynmanliang avatar May 09 '22 18:05 feynmanliang

@zaxtax has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar May 09 '22 19:05 facebook-github-bot

@feynmanliang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 10 '22 20:05 facebook-github-bot