beanmachine
beanmachine copied to clipboard
facebookresearch
Remove StatisticalModel class and add typeguards
Summary: The StatisticalModel class was a class with only static methods. I've removed the class and made the static methods module-level functions.
I've also add two "typeguards" to help prove to the type checker that we've narrowed Union[RVIdentifier, torch.Tensor] to RVIdentifier appropriately.
I also was able to work around a mysterious Pyre issue by rewriting a * (1 / b) as a / b in abstract_conjugate.py.
Differential Revision: D34979861
Hi @ToddSmall!
Thank you for your pull request.
We require contributors to sign our Contributor License Agreement, and yours needs attention.
You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!