beanmachine icon indicating copy to clipboard operation
beanmachine copied to clipboard

Published 20 hours ago • verified publisher icon facebookresearch

Linear Regression tutorial excess logging fix

Open likethesky opened this issue 2 years ago • 4 comments

Motivation

Fixes the excess logging for the NMC inferences--both of them--in this tutorial

Changes proposed

Set log level to 50, so only progress bars are shown/logged during NMC inference, return back to 0 after finished.

Test Plan

Observe via Colab links.

Types of changes

  • [x] Docs change / refactoring / dependency upgrade
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.
  • [ ] The title of my pull request is a short description of the requested changes.

likethesky avatar Dec 14 '21 20:12 likethesky

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

review-notebook-app[bot] avatar Dec 14 '21 20:12 review-notebook-app[bot]

@michaeltingley has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot avatar Dec 14 '21 21:12 facebook-github-bot

Hi @likethesky!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Nov 10 '23 21:11 facebook-github-bot

thanks @likethesky I haven't had a chance to look at this just yet, but it is in my todo list and has not dropped off my radar

ndmlny-qs avatar Dec 11 '23 22:12 ndmlny-qs