ParlAI icon indicating copy to clipboard operation
ParlAI copied to clipboard

Fix the api call and api response mismatch issue

Open jacksukk opened this issue 3 years ago • 2 comments

This PR is to

  1. Fixed a bug: also consider cum_api_call when processing the goal_calls
  2. In taskmaster2 data structure, sometime there's api response in system without user api call. And it will cause problems when people want to implement lookup table DB in the simulation scenario. So, using len(cum_api_call) > 0 and len(api_resp) > 0 as a constraint.

jacksukk avatar Oct 04 '22 18:10 jacksukk

cc @moyapchen unless you think someone else should review?

klshuster avatar Nov 03 '22 16:11 klshuster

Hi @jacksukk!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Nov 09 '22 22:11 facebook-github-bot

This PR has not had activity in 30 days. Closing due to staleness.

github-actions[bot] avatar Dec 10 '22 00:12 github-actions[bot]