ParlAI icon indicating copy to clipboard operation
ParlAI copied to clipboard

Fixed T5 and GPT2 related bugs in the hugging_face agents

Open michaelsaxon opened this issue 3 years ago • 3 comments

Patch description Previously T5 dictionary was undefined and elements of the huggingface dictionary agent were uninitialized leading to immediate exceptions in the train step for T5 and at the beginning of the validation step for GPT2 when training using train_model.py and the latest versions of HuggingFace

Testing steps Verify that python parlai/scripts/train_model.py --m hugging_face/t5 --t multiwoz_v22 --mf ~/t5test --truncate 512 --vstep 150 --max-train-steps 300 and python parlai/scripts/train_model.py --m hugging_face/gpt2 --t multiwoz_v22 --mf ~/gpt2test --truncate 512 --vstep 150 --max-train-steps 300 successfully terminate without exceptions

Other information As discussed with Kurt and Andrew previously

michaelsaxon avatar Jul 06 '22 01:07 michaelsaxon

This PR has not had activity in 30 days. Closing due to staleness.

github-actions[bot] avatar Aug 12 '22 00:08 github-actions[bot]

Is there any update here?

klshuster avatar Aug 15 '22 16:08 klshuster

Hi @michaelsaxon!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Sep 24 '22 07:09 facebook-github-bot

closing in favor of #5016

klshuster avatar Apr 18 '23 16:04 klshuster