ParlAI icon indicating copy to clipboard operation
ParlAI copied to clipboard

"maxlen" in parlai.core.torch_agent.History actually does nothing

Open Reveyer opened this issue 4 years ago • 2 comments

https://github.com/facebookresearch/ParlAI/blob/c7f4b64df1a706464c053f036fe2ff38600f4558/parlai/core/torch_agent.py#L209

I think the description

  • maxlen – sets the maximum number of tunrs

should be changed to

  • size – sets the maximum number of tunrs

Reveyer avatar Aug 26 '20 18:08 Reveyer

Good catch. I’d welcome a PR

stephenroller avatar Aug 28 '20 00:08 stephenroller

This issue has not had activity in 30 days. Please feel free to reopen if you have more issues. You may apply the "never-stale" tag to prevent this from happening.

github-actions[bot] avatar Sep 27 '20 00:09 github-actions[bot]