ImageBind
ImageBind copied to clipboard
facebookresearch
Added cache_dir argument for downloading model to a specific directory
The current code only supports downloading to the .checkpoints directory. This PR adds functionality to download model checkpoints to a specific directory with the cache_dir argument to models.imagebind_model.imagebind_huge().
Hi @vishaal27!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Thanks for your contribution. Could you please set the default cache dir=".checkpoints/imagebind_huge.pth" such that the current behaviour does not change ?
Hey, the code is implemented such that if the cache_dir is not set, it defaults to the original behaviour of downloading the checkpoint to ".checkpoints/imagebind_huge.pth"
For reference, see these two lines: https://github.com/vishaal27/ImageBind/blob/4d30ff11e3ecc5eab9d10fc603b090d950d49613/models/imagebind_model.py#L504-L505
Essentially for now, the cache_dir defaults to ".checkpoints" and the name of the checkpoint is always "imagebind_huge.pth".
However, if you'd like to me to change this to couple both the cache_dir and the name of the checkpoint file itself into one argument, happy to do so, please let me know.