ImageBind icon indicating copy to clipboard operation
ImageBind copied to clipboard

Upgrade dependencies & replace deprecated modules with modern alternatives

Open ahmedsaed opened this issue 10 months ago • 2 comments

This PR upgrades some project dependencies and replaces deprecated modules with their recommended alternatives.

Upgraded dependencies:

  • torch>=2.0.0
  • pytorchvideo to commit 6cdc9 (latest at the time of making the PR)
  • timm to latest

Replaced deprecated modules:

  • torchvision.transforms._transforms_video.NormalizeVideo with torchvision.transforms.Normalize

I have tested these changes in this colab notebook using the example provided in the README.md.

ahmedsaed avatar Feb 25 '25 22:02 ahmedsaed

Fixed the issues I ran into with the current installation procedure. Just had to modify a couple of the import statements to reflect their current implementation. One of them was torchvision.transforms.functional_tensor (became torchvision.transforms.functional) within the torchvision package and the other was the same in two of imagebind's files (timm.layers became timm.modules.layers).

ajland avatar Apr 22 '25 05:04 ajland

Fixed the issues I ran into with the current installation procedure. Just had to modify a couple of the import statements to reflect their current implementation. One of them was torchvision.transforms.functional_tensor (became torchvision.transforms.functional) within the torchvision package and the other was the same in two of imagebind's files (timm.layers became timm.modules.layers).

I couldn't find any references to functional_tensor in the code. Can you provide more details? I don't believe the timm v1.0.15 has timm.modules.layers.

The provided changes in this PR works with the versions defined in requirements.txt. I have tested it in multiple experiments.

ahmedsaed avatar Apr 24 '25 11:04 ahmedsaed

In https://github.com/facebookresearch/ImageBind/pull/136/commits/7436d3a4490a294c762610a34ea8058171f8e22c, I removed some deps from the requirements.txt as I can't seem to find any references or imports in the code. This should make the installation easier and faster.

ahmedsaed avatar May 10 '25 22:05 ahmedsaed

The current HEAD 3fcf5c9039de97f6ff5528ee4a9dce903c5979b3 does not work with modern dependencies. This PR makes ImageBind usable again for me (hopefully it will get merged), thanks @ahmedsaed!

marblestation avatar Jun 03 '25 19:06 marblestation

Any plans to merge it? The current version of ImageBind is broken anyway (for non-outdated versions of the dependencies)

universome avatar Sep 10 '25 00:09 universome