velox
velox copied to clipboard
Pass CMAKE_PREFIX_PATH for Arrow third-party compilation
Passing CMAKE_PREFIX_PATH for Arrow third-party compilation could fix issues like #9953 .
Hi @JinHelin404!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Deploy Preview for meta-velox canceled.
| Name | Link |
|---|---|
| Latest commit | 8e0865d171f403eea4defcb12bac6745803a645b |
| Latest deploy log | https://app.netlify.com/sites/meta-velox/deploys/6686704a3612b30008b5cc5a |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
@xiaoxmeng Could you please take a look of this? Just a minor fix.
@JinHelin404 Can you rebase with the main branch?
@JinHelin404 Can you rebase with the main branch?
@majetideepak done.
@pedroerp has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@pedroerp merged this pull request in facebookincubator/velox@319bc2cf8c6314073b1936ea373354fc5f161773.
Conbench analyzed the 1 benchmark run on commit 319bc2cf.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details.