velox icon indicating copy to clipboard operation
velox copied to clipboard

Fix NaN handling for array_min and array_max

Open bikramSingh91 opened this issue 9 months ago • 6 comments

Summary: Ensure that:

  • Null is returned consistently for all types
  • NaN is treated as greater than infinity

Differential Revision: D57237545

bikramSingh91 avatar May 11 '24 00:05 bikramSingh91

Deploy Preview for meta-velox canceled.

Name Link
Latest commit c112e4924b94e115b9608bbf899a43789975438d
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/66468c7a0eccce0008516b71

netlify[bot] avatar May 11 '24 00:05 netlify[bot]

This pull request was exported from Phabricator. Differential Revision: D57237545

facebook-github-bot avatar May 11 '24 00:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57237545

facebook-github-bot avatar May 13 '24 17:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57237545

facebook-github-bot avatar May 13 '24 18:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57237545

facebook-github-bot avatar May 13 '24 18:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57237545

facebook-github-bot avatar May 13 '24 23:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57237545

facebook-github-bot avatar May 15 '24 21:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57237545

facebook-github-bot avatar May 15 '24 21:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57237545

facebook-github-bot avatar May 16 '24 22:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57237545

facebook-github-bot avatar May 16 '24 22:05 facebook-github-bot

This pull request has been merged in facebookincubator/velox@c856374347054bb6367725ed6f9e3a4d23af9de4.

facebook-github-bot avatar May 20 '24 20:05 facebook-github-bot

Conbench analyzed the 1 benchmark run on commit c8563743.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

conbench-facebook[bot] avatar May 20 '24 21:05 conbench-facebook[bot]