velox
velox copied to clipboard
Published
20 hours ago •
facebookincubator
facebookincubator
Fix handling of NaN for map variants
Summary: Highlights of the this change:
- Introduces a utility functors for floating point types that provide comparator and hash functor to implement consistent behavior or NaNs across the codebase. These can be passed to standard containers and functions like std::map and std::sort, etc.
- These utility functors will be used in upcoming changes to fixes for NaN behavior across the codebase wherever folly or std containers or functions are used that can accept such functors.
- Fix NaN handling of floating points for map variants which uses a std::map to hold key and value variants. Without this, using NaN as a key would result in an inconsistent state because NaN cannot be compared with other values. This resulted in inconsistent comparison of map vectors in tests where QueryAssertions.h uses a map variant to compare such vectors. (See asserEqualResults())
Differential Revision: D57187815
Deploy Preview for meta-velox canceled.
| Name | Link |
|---|---|
| Latest commit | f4896c36bdb25db94b33af47c853a986146f5cf3 |
| Latest deploy log | https://app.netlify.com/sites/meta-velox/deploys/66468c1d1ea50c00082f4dd2 |
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request has been merged in facebookincubator/velox@8f3c806e6c74e29a1209047752730bc474f10409.