velox icon indicating copy to clipboard operation
velox copied to clipboard

Vectorizing merge join

Open pedroerp opened this issue 9 months ago • 2 comments

Summary: Changing the merge join algorithm to avoid the copy to a new output buffer and rather wrapping the input left and right using dictionaries. Left buffers are always wrapped, and right are wrapped unless the output spans more than one right buffer (in which case it gets flattened). . The new version shows a ~10x speed up over the existing code, and about 4x speed up in a real end to end pipeline.

Differential Revision: D57146000

pedroerp avatar May 09 '24 20:05 pedroerp

This pull request was exported from Phabricator. Differential Revision: D57146000

facebook-github-bot avatar May 09 '24 20:05 facebook-github-bot

Deploy Preview for meta-velox canceled.

Name Link
Latest commit 4181b69eec3986707c2f2d2bc79740e73bd9198a
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/665a6534a281d000083a2716

netlify[bot] avatar May 09 '24 20:05 netlify[bot]

This pull request was exported from Phabricator. Differential Revision: D57146000

facebook-github-bot avatar May 22 '24 02:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57146000

facebook-github-bot avatar May 29 '24 21:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57146000

facebook-github-bot avatar May 29 '24 21:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57146000

facebook-github-bot avatar May 29 '24 23:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57146000

facebook-github-bot avatar May 29 '24 23:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57146000

facebook-github-bot avatar Jun 01 '24 00:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57146000

facebook-github-bot avatar Jun 01 '24 00:06 facebook-github-bot

This pull request has been merged in facebookincubator/velox@7773f764e75ce6e2b2d12749ee2d82a3142b45e3.

facebook-github-bot avatar Jun 01 '24 18:06 facebook-github-bot

Conbench analyzed the 1 benchmark run on commit 7773f764.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

conbench-facebook[bot] avatar Jun 01 '24 19:06 conbench-facebook[bot]